Skip to content

Remove old node gitignore targets#3803

Merged
nycrat merged 1 commit into
UBC-Thunderbots:masterfrom
nycrat:avah/remove_node_gitignore
Jun 25, 2026
Merged

Remove old node gitignore targets#3803
nycrat merged 1 commit into
UBC-Thunderbots:masterfrom
nycrat:avah/remove_node_gitignore

Conversation

@nycrat

@nycrat nycrat commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

Like 8 years ago in #110, we implemented a visualizer that used javascript/node. These gitignore targets were added then, but are now causing issues on MacOS where gitignore is case insensitive by default. The specific target *build also targets BUILD files for bazel (I've been manually force git adding these targets and now I realize this was the issue.

This PR just removes these old Node .gitignore targets because they are not relevant anymore.

Testing Done

Checked the repo for all the gitignore targets, they don't exist anymore

Resolved Issues

N/A

Length Justification and Key Files to Review

N/A

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat merged commit 8fef866 into UBC-Thunderbots:master Jun 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants